update comments and exception related to kvm.snapshot.enabled setting - #13733
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the in-code documentation and runtime exception text related to the kvm.snapshot.enabled global setting, clarifying how it affects snapshot support for running VMs on KVM.
Changes:
- Renames a private helper to fix a spelling error (
hostSupportsSnapsthotForVolume→hostSupportsSnapshotForVolume). - Updates comments describing
kvm.snapshot.enabledbehavior for KVM volume snapshots. - Rewords the exception thrown when snapshots are blocked for running VMs due to
kvm.snapshot.enabled=false.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java |
Fixes helper method spelling and updates KVM snapshot-related comment and exception message text. |
server/src/main/java/com/cloud/storage/snapshot/SnapshotManager.java |
Minor wording fix in the kvm.snapshot.enabled ConfigKey description. |
Comments suppressed due to low confidence (1)
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java:1593
- This exception message is internally inconsistent: it says kvm.snapshot.enabled is already set to false, then immediately says "It can be disabled". Consider rephrasing to explain that it is sometimes set to false to avoid corruption, and how to re-enable it.
"KVM Snapshot is not supported for Running VMs because the global setting " +
"kvm.snapshot.enabled is set to false for this deployment. It can be disabled to " +
"avoid a possible volume corruption in certain cases. To allow snapshots of running " +
"VMs, set kvm.snapshot.enabled to true. See the documentation for more details.");
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13733 +/- ##
============================================
+ Coverage 19.65% 20.27% +0.61%
- Complexity 19792 20630 +838
============================================
Files 6368 6371 +3
Lines 574881 591956 +17075
Branches 70351 77056 +6705
============================================
+ Hits 112970 119990 +7020
- Misses 449639 459173 +9534
- Partials 12272 12793 +521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
@DaanHoogland makes sense |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19171 |
Description
This PR fixes comment and exception related to kvm.snapshot.enabled setting.
Doc PR: apache/cloudstack-documentation#673
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?